Do not bind DTLS for Qt 5 QNetwork causing issues on macOS #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mappu
force-pushed
the
miqt-block-qnetwork-dtls
branch
from
902bdd8 to
a64339b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #151
Qt 5 on macOS uses Apple Secure Transport by default, including in the Brew distribution. This TLS library does not support DTLS and any attempt to use
qdtls.hthrows an#error.Since DTLS is not widely used, block the binding generation for qdtls.h (on all operating systems). Future work could be to make this OS-dependent (see #59).
Additional minor changes in this PR:
make clean-cache.PHONY target to clear the genbindings cache