Connect to new endpoint for fetching specifically task markers #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2356 +/- ##
==========================================
- Coverage 23.51% 23.47% -0.04%
==========================================
Files 649 649
Lines 22502 22543 +41
Branches 6928 6962 +34
==========================================
+ Hits 5292 5293 +1
- Misses 14398 14425 +27
- Partials 2812 2825 +13 ☔ View full report in Codecov by Sentry. |
CollinBeczak
force-pushed
the
connect-to-new-endpoint-for-fetching-specifically-task-markers
branch
from
6d15d50 to
6d12185
Compare
CollinBeczak
force-pushed
the
connect-to-new-endpoint-for-fetching-specifically-task-markers
branch
from
1ec4d33 to
cd66497
Compare
CollinBeczak
force-pushed
the
connect-to-new-endpoint-for-fetching-specifically-task-markers
branch
from
cd66497 to
7054879
Compare
CollinBeczak
force-pushed
the
connect-to-new-endpoint-for-fetching-specifically-task-markers
branch
from
7054879 to
f231806
Compare
jake-low
reviewed
Dec 2, 2024
src/services/Task/BoundedTask.js
Outdated
| // If we are searching within map bounds we need to ensure the parent | ||
| // challenge is also within those bounds | ||
| if (filters.location === CHALLENGE_LOCATION_WITHIN_MAPBOUNDS) { | ||
| if (_isArray(criteria.boundingBox)) { |
There was a problem hiding this comment.
Array.isArray() would work here
src/services/Task/BoundedTask.js
Outdated
Comment on lines
137
to
140
| return { | ||
| tasks, | ||
| totalCount | ||
| } |
There was a problem hiding this comment.
Does fetchBoundedTaskMarkers need to return both the array of tasks and the array's length? Seems redundant.
src/services/Task/BoundedTask.js
Outdated
| * criteria, which should at least include a boundingBox field, and may | ||
| * optionally include a filters field with additional constraints | ||
| */ | ||
| export const fetchBoundedTaskMarkers = function(criteria, limit = 50, skipDispatch = false, ignoreLocked = true) { |
There was a problem hiding this comment.
Nit: you can write export function fetchBoundedTaskMarkers(criteria, ...) { instead; it's shorter.
Co-authored-by: Jake Low <[email protected]>
Co-authored-by: Jake Low <[email protected]>
Co-authored-by: Jake Low <[email protected]>
Co-authored-by: Jake Low <[email protected]>
Co-authored-by: Jake Low <[email protected]>
Co-authored-by: Jake Low <[email protected]>
jake-low
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #2354
Paired with and dependent on: maproulette/maproulette-backend#1130
Issue: The old endpoint used for fetching task markers was needlessly complex and slow.
This PR connect to the simpler endpoint used to fetch specifically marker data.