Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add review changes notice to tag fix completion modal #2482

Merged
merged 8 commits into from
Nov 10, 2024

Conversation

CollinBeczak
Copy link
Collaborator

Potentially resolved: #2405

Example of modal before proposed change:
Screenshot 2024-10-28 at 1 52 12 PM

Example of modal after proposed change:
Screenshot 2024-10-28 at 1 52 49 PM

@CollinBeczak CollinBeczak marked this pull request as ready for review November 6, 2024 20:59
@CollinBeczak CollinBeczak requested a review from jake-low November 6, 2024 20:59
@CollinBeczak CollinBeczak force-pushed the collin/tag-fix-osmchangeset-notice branch from dfcb8c1 to 00db4ed Compare November 7, 2024 21:58
@CollinBeczak
Copy link
Collaborator Author

CollinBeczak commented Nov 8, 2024

Screenshot 2024-11-08 at 12 43 59 PM

@CollinBeczak CollinBeczak requested a review from jake-low November 8, 2024 18:48
Copy link
Contributor

@jake-low jake-low left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM.

@CollinBeczak CollinBeczak merged commit c51f9e4 into main Nov 10, 2024
5 of 6 checks passed
@CollinBeczak CollinBeczak deleted the collin/tag-fix-osmchangeset-notice branch November 10, 2024 00:27
@CollinBeczak CollinBeczak mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Tag Fix UX to make it clearer that the mapper is direcly editing OSM
2 participants