Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when reprojecting coordinates #374

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Fix bug when reprojecting coordinates #374

merged 1 commit into from
Mar 28, 2024

Conversation

rwood-97
Copy link
Collaborator

Summary

Thanks to @DGalexander for flagging this.

This PR fixes mapreader's reproject coords functions when converting between coordinate systems.

Describe your changes

  • coords are transformed from bounds: (left, bottom, right, top) == (xmin, ymin, xmax, ymax)
  • always_xy is set to True to ensure no variation between crs ordering

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@rwood-97 rwood-97 requested a review from DGalexander March 27, 2024 08:31
@rwood-97 rwood-97 merged commit de910b4 into main Mar 28, 2024
4 checks passed
@rwood-97 rwood-97 deleted the coords_bug_fix branch March 28, 2024 09:10
@rwood-97 rwood-97 added the bug Something isn't working label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants