-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android, builders fluent setters, AutoValue #61
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Arberg,
Sorry for leaving this dangling so long. I am tying together some loose ends and came across this PR of yours.
While executing the gradle build I ran into an error: SDK location not found. Define location with sdk.dir in the local.properties file or with an ANDROID_HOME environment variable.
Is this SDK really needed for this case? It makes it hard to run it as a minimal example. Note: auto value is not really dependent on android.
Hi Sjaak, Yeah I can see why that's a problem. You need android-sdk to compile it, and I can see why you wouldn't want to add that as a compile dependency. I cannot compile the other tests. I use intellij and gradle, and don't know how to setup compilation on map-struct-test. One option forward would be to just move the code to a non-android package like the others, there are lots of the samples, that are not elsewhere in the samples. Additionally we might link the android project, https://github.com/abeade/mapstruct-test which includes mapstruct in an android codebase. Best Alex |
Hey Alex, I'll have how to merge your example I'm not so fluent in gradle, so it will take some some time. Thanks for your contribution, |
You are welcome. I'll be here if you have other questions, and if you decide to avoid Android, no problem. Best Alex |
No description provided.