Skip to content

Commit

Permalink
fix(project-view): do not wait for updated projectContributions when …
Browse files Browse the repository at this point in the history
…mapping speed < 125 ms per task
  • Loading branch information
ofr1tz committed Jun 5, 2024
1 parent c435e6d commit db85248
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions src/views/ProjectView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export default defineComponent({
completedGroupId: null,
group: null,
mode: 'contribute',
mappingSpeed: 1,
nextDialog: false,
project: null,
projectContributions: [],
Expand All @@ -51,8 +52,12 @@ export default defineComponent({
logAnalyticsEvent('mapping_started', { projectType: projectType })
},
saveResults: (results, startTime) => {
const numberOfTasks = Object.keys(results).length
const endTime = new Date().toISOString()
this.mappingSpeed = (Date.parse(endTime) - Date.parse(startTime)) / numberOfTasks
const entry = {
endTime: new Date().toISOString(),
endTime,
results,
startTime,
}
Expand Down Expand Up @@ -190,7 +195,12 @@ export default defineComponent({
const updated =
this.projectContributions[this.completedGroupId] &&
this.completedGroupId !== this.group?.groupId
return updated
/*
Firebase rejects results that are produced at a speed of less than 125 ms per task. Therefore, we do not wait for
updated projectContributions for speedy results.
*/
const tooSpeedy = this.mappingSpeed < 125
return updated || tooSpeedy
}
},
handleTaskComponentCreated() {
Expand Down

0 comments on commit db85248

Please sign in to comment.