refactor: moved code under modules

marabesi · Jun 30, 2024 · f8211a0 · f8211a0
1 parent a0fae6c
commit f8211a0
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 17 deletions.
diff --git a/vscode/package.json b/vscode/package.json
@@ -43,7 +43,7 @@
     "test:all": "mocha -r ts-node/register src/modules/**/**.test.ts",
     "test:coverage": "nyc --reporter=text mocha -r ts-node/register src/modules/**/**.test.ts",
     "coveralls": "npm run test:coveralls:coverage && coveralls --verbose < lcov.info",
-    "cli": "ts-node src/cli/find-smells.ts"
+    "cli": "ts-node src/modules/cli/find-smells.ts"
   },
   "devDependencies": {
     "@types/esprima": "^4.0.6",

diff --git a/vscode/src/extension.ts b/vscode/src/extension.ts
@@ -1,7 +1,7 @@
 import * as vscode from 'vscode';
 import path from 'path';
-import { SmellDetector } from './modules/smells-detector';
-import { Smell } from './modules/types';
+import { SmellDetector } from './modules/smells-finder/smells-detector';
+import { Smell } from './modules/smells-finder/types';
 import { ComposedSmell, warningDecorationType } from './extension.types';
 
 let currentDecoration = warningDecorationType;

diff --git a/vscode/src/extension.types.ts b/vscode/src/extension.types.ts
@@ -1,5 +1,5 @@
 import { Range, window } from 'vscode';
-import { Smell } from "./modules/types";
+import { Smell } from "./modules/smells-finder/types";
 
 export type ComposedSmell = {
   smell: Smell;

diff --git a/vscode/src/modules/SmellsFinder.ts b/vscode/src/modules/SmellsFinder.ts
diff --git a/vscode/src/cli/find-smells.ts → vscode/src/modules/cli/find-smells.ts b/vscode/src/cli/find-smells.ts → vscode/src/modules/cli/find-smells.ts
@@ -1,5 +1,5 @@
 import fs from 'node:fs/promises';
-import { SmellDetector } from '../modules/smells-detector';
+import { SmellDetector } from '../smells-finder/smells-detector';
 
 const args = process.argv;
 const fileName = args[2];

diff --git a/vscode/src/modules/JavascriptSmells.ts → ...ells-finder/languages/JavascriptSmells.ts b/vscode/src/modules/JavascriptSmells.ts → ...ells-finder/languages/JavascriptSmells.ts
@@ -1,6 +1,5 @@
 import { Syntax, parseScript } from "esprima";
-import { SmellsFinder } from "./SmellsFinder";
-import { Smell } from "./types";
+import { Smell, SmellsFinder } from "../types";
 
 export class JavascriptSmells implements SmellsFinder {
 

diff --git a/vscode/src/modules/TypescriptSmells.ts → ...ells-finder/languages/TypescriptSmells.ts b/vscode/src/modules/TypescriptSmells.ts → ...ells-finder/languages/TypescriptSmells.ts
@@ -1,7 +1,6 @@
 import * as ts from 'typescript';
 
-import { SmellsFinder } from "./SmellsFinder";
-import { Smell } from "./types";
+import { Smell, SmellsFinder } from "../types";
 
 export class TypescriptSmells implements SmellsFinder {
 

diff --git a/vscode/src/modules/smells-detector.ts → .../modules/smells-finder/smells-detector.ts b/vscode/src/modules/smells-detector.ts → .../modules/smells-finder/smells-detector.ts
@@ -1,5 +1,5 @@
-import { JavascriptSmells } from './JavascriptSmells';
-import { TypescriptSmells } from './TypescriptSmells';
+import { JavascriptSmells } from './languages/JavascriptSmells';
+import { TypescriptSmells } from './languages/TypescriptSmells';
 import { Smell } from './types';
 
 export class SmellDetector {

diff --git a/.../src/modules/test/smells-detector.test.ts → ...mells-finder/test/smells-detector.test.ts b/.../src/modules/test/smells-detector.test.ts → ...mells-finder/test/smells-detector.test.ts
diff --git a/vscode/src/modules/types.ts → vscode/src/modules/smells-finder/types.ts b/vscode/src/modules/types.ts → vscode/src/modules/smells-finder/types.ts
@@ -6,4 +6,8 @@ export type Smell = {
   endsAt: number;
   description: string; //supports markdown
   diagnostic: string; //no support for markdown
-};
+};
+
+export interface SmellsFinder {
+  searchSmells(): Smell[];
+}