Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New AnimatedPosition component #1013

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Dec 17, 2024

Depends on #1015

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Dec 17, 2024
@marc2332
Copy link
Owner Author

Notes: I don't like the name of fixed, maybe global is better?

Copy link

Benchmark for 6173e51

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 103.3±1.00ms 104.9±0.78ms +1.55%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 25.1±0.88ms 27.5±1.10ms +9.56%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1366.2±44.01µs 1527.9±13.82µs +11.84%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 132.0±1.36µs 148.4±1.58µs +12.42%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.8±0.69ms 25.0±0.56ms +0.81%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1684.3±13.29µs 1738.5±21.73µs +3.22%
benchmarks/size=19531 depth=7 wide=5 mode=cached 322.5±20.71µs 321.3±19.94µs -0.37%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.03ms 2.8±0.07ms +7.69%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 418.4±154.88µs 430.3±121.54µs +2.84%
benchmarks/size=54241 depth=5 wide=15 mode=cached 263.7±28.62µs 265.1±37.38µs +0.53%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.3±0.13ms 7.8±0.24ms +23.81%

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 28.76712% with 104 lines in your changes missing coverage. Please review.

Project coverage is 73.84%. Comparing base (59915b5) to head (6be8050).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/torin/src/values/position.rs 29.09% 39 Missing ⚠️
crates/components/src/animated_position.rs 0.00% 34 Missing ⚠️
crates/hooks/src/use_node.rs 0.00% 27 Missing ⚠️
crates/hooks/src/use_animation.rs 62.50% 3 Missing ⚠️
crates/state/src/values/position.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
- Coverage   74.15%   73.84%   -0.32%     
==========================================
  Files         215      217       +2     
  Lines       24685    24897     +212     
==========================================
+ Hits        18305    18384      +79     
- Misses       6380     6513     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 changed the base branch from main to fix/handle-reordering-of-keyed-children December 18, 2024 20:23
Copy link

Benchmark for 6abde56

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 104.4±2.37ms 104.2±2.45ms -0.19%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.3±1.66ms 26.0±1.46ms +7.00%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1354.9±11.21µs 1387.5±48.53µs +2.41%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 131.0±1.23µs 134.0±1.51µs +2.29%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.2±0.58ms 24.8±0.50ms +2.48%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1683.9±39.19µs 1685.8±12.72µs +0.11%
benchmarks/size=19531 depth=7 wide=5 mode=cached 313.9±9.20µs 318.7±17.29µs +1.53%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.01ms 2.6±0.07ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 410.9±148.73µs 416.4±194.23µs +1.34%
benchmarks/size=54241 depth=5 wide=15 mode=cached 254.3±16.29µs 253.0±27.29µs -0.51%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.3±0.16ms 6.3±0.09ms 0.00%

Copy link

Benchmark for 8b9a8af

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 103.3±2.88ms 106.4±1.00ms +3.00%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 25.2±0.82ms 25.7±1.01ms +1.98%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1373.4±22.87µs 1394.0±14.19µs +1.50%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 133.3±1.33µs 134.2±2.82µs +0.68%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.2±0.66ms 24.3±0.60ms +0.41%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1686.2±10.48µs 1677.9±13.62µs -0.49%
benchmarks/size=19531 depth=7 wide=5 mode=cached 312.6±5.49µs 322.9±12.90µs +3.29%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.5±0.03ms 2.6±0.13ms +4.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 411.5±115.24µs 415.7±154.26µs +1.02%
benchmarks/size=54241 depth=5 wide=15 mode=cached 250.0±22.68µs 289.9±70.29µs +15.96%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.2±0.08ms 6.7±0.49ms +8.06%

Base automatically changed from fix/handle-reordering-of-keyed-children to main December 19, 2024 20:29
Copy link

Benchmark for 1d29e69

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 104.9±1.57ms 105.3±0.95ms +0.38%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 27.1±1.19ms 26.3±1.52ms -2.95%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1393.0±61.62µs 1382.5±11.65µs -0.75%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 132.2±1.49µs 134.3±1.15µs +1.59%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.2±0.57ms 25.5±0.77ms +1.19%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1729.2±48.78µs 1717.6±20.13µs -0.67%
benchmarks/size=19531 depth=7 wide=5 mode=cached 318.7±25.74µs 343.3±16.59µs +7.72%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.8±0.03ms 2.6±0.04ms -7.14%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 414.3±89.96µs 414.0±56.59µs -0.07%
benchmarks/size=54241 depth=5 wide=15 mode=cached 273.4±29.07µs 280.0±40.37µs +2.41%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.3±0.14ms 6.4±0.23ms +1.59%

Copy link

Benchmark for 6b35aba

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 104.3±1.85ms 104.9±1.21ms +0.58%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 26.1±0.70ms 26.7±1.24ms +2.30%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1385.1±27.74µs 1399.3±11.92µs +1.03%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 135.9±10.93µs 133.7±1.48µs -1.62%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.9±1.47ms 25.3±0.72ms -2.32%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1704.4±57.96µs 1695.6±17.76µs -0.52%
benchmarks/size=19531 depth=7 wide=5 mode=cached 315.9±15.64µs 319.6±9.23µs +1.17%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.02ms 2.6±0.10ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 411.2±91.98µs 411.7±57.66µs +0.12%
benchmarks/size=54241 depth=5 wide=15 mode=cached 249.6±20.66µs 251.4±20.40µs +0.72%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.2±0.39ms 6.3±0.17ms +1.61%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant