Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: visible_width & visible_height #1072

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Conversation

marc2332
Copy link
Owner

Closes #1018

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jan 29, 2025
@marc2332 marc2332 modified the milestone: 0.3.0 Jan 29, 2025
Copy link

Benchmark for a8b23f7

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 111.9±0.84ms 112.9±0.90ms +0.89%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 28.5±0.76ms 29.4±1.55ms +3.16%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1437.5±43.10µs 1460.4±209.32µs +1.59%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 137.9±2.30µs 137.3±3.51µs -0.44%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 27.8±1.58ms 28.3±1.03ms +1.80%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1819.1±55.56µs 1931.4±75.61µs +6.17%
benchmarks/size=19531 depth=7 wide=5 mode=cached 454.9±39.77µs 365.1±44.92µs -19.74%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.9±0.15ms 2.7±0.07ms -6.90%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 414.6±48.12µs 424.2±61.19µs +2.32%
benchmarks/size=54241 depth=5 wide=15 mode=cached 427.4±49.65µs 305.6±18.09µs -28.50%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.5±0.48ms 7.2±0.42ms -4.00%

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 61.42857% with 27 lines in your changes missing coverage. Please review.

Project coverage is 73.46%. Comparing base (d6f4b65) to head (a33a116).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/devtools/src/tabs/style.rs 0.00% 9 Missing ⚠️
crates/core/src/node.rs 0.00% 8 Missing ⚠️
crates/torin/src/values/visible_size.rs 37.50% 5 Missing ⚠️
crates/state/src/layout.rs 33.33% 4 Missing ⚠️
crates/state/src/values/visible_size.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   73.50%   73.46%   -0.04%     
==========================================
  Files         221      223       +2     
  Lines       27333    27382      +49     
==========================================
+ Hits        20091    20117      +26     
- Misses       7242     7265      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit ebbdd85 into main Jan 29, 2025
7 of 8 checks passed
@marc2332 marc2332 deleted the feat/visible-width-and-height branch January 29, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto percentages take priority over max and min sizes
1 participant