Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve Input component #354

Merged
merged 37 commits into from
Nov 3, 2023
Merged

feat: Improve Input component #354

merged 37 commits into from
Nov 3, 2023

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Oct 22, 2023

Depends on #330
Depends on #360
Depends on #359
Depends on #353

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Oct 22, 2023
@marc2332 marc2332 changed the title feat: Improve input feat: Improve Input component Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (e673992) 53.72% compared to head (97fa928) 53.61%.

❗ Current head 97fa928 differs from pull request most recent head 13979be. Consider uploading reports for the commit 13979be to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   53.72%   53.61%   -0.12%     
==========================================
  Files         133      133              
  Lines       12047    12072      +25     
==========================================
  Hits         6472     6472              
- Misses       5575     5600      +25     
Files Coverage Δ
crates/core/src/events.rs 96.29% <100.00%> (ø)
crates/elements/src/elements.rs 26.66% <ø> (ø)
crates/components/src/input.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/set-cursor-shortcut to feat/enhanced-alignments October 23, 2023 06:29
@marc2332 marc2332 changed the base branch from feat/enhanced-alignments to feat/set-cursor-shortcut October 23, 2023 06:42
Base automatically changed from feat/set-cursor-shortcut to main October 26, 2023 21:14
@marc2332 marc2332 merged commit 9fc0270 into main Nov 3, 2023
4 checks passed
@marc2332 marc2332 deleted the feat/improve-input branch November 3, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant