fix: Abandon context if not current when closing the app #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 53.11% 53.08% -0.03%
==========================================
Files 147 147
Lines 12989 12996 +7
==========================================
Hits 6899 6899
- Misses 6090 6097 +7 ☔ View full report in Codecov by Sentry. |
tronical
reviewed
Oct 23, 2023
| @@ -46,6 +47,14 @@ pub struct WindowEnv<T: Clone> { | |||
| pub(crate) window_config: WindowConfig<T>, | |||
| } | |||
|
|
|||
| impl<T: Clone> Drop for WindowEnv<T> { | |||
| fn drop(&mut self) { | |||
| if !self.gl_context.is_current() { | |||
There was a problem hiding this comment.
I suggest to try to make the context current and only abandon if making it current fails.
marc2332
deleted the
fix/abandon-context-if-not-current-when-closing-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.