feat: Add Link component back

[tigerros]

Features

• Add Link, which works like Dioxus router's Link. Example code:

  rsx! {
      Link { to: Route::Foo {}, label { "Route default (no tooltip)" } }
      Link { to: Route::Bar {}, tooltip: AnchorTooltip::Custom("Bar".to_string()), label { "Custom tooltip" } }
      Link { to: "https://github.com/marc2332/freya", label { "URL default (URL value tooltip)" } }
      Link { to: "https://github.com/marc2332/freya", tooltip: AnchorTooltip::None, label { "URL no tooltip" } }
  }

• Optimize ExternalLink a bit.

Notes

• This makes ExternalLink obsolete, except for theming.
• Link might be a better name.
• This doesn't add any styles or themes. I think components should add the minimum amount of style. They can be wrapped in a rect to add shadows, change color, etc., but it's impossible to remove styles. As for the themes, I just didn't bother adding them, which is why this is a draft.

[codecov]

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (8b9f961) 54.22% compared to head (8f14b66) 54.28%.
Report is 1 commits behind head on main.

❗ Current head 8f14b66 differs from pull request most recent head 0e0b66f. Consider uploading reports for the commit 0e0b66f to get more accurate results

Files	Patch %	Lines
crates/components/src/link.rs	0.00%	23 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   54.22%   54.28%   +0.05%     
==========================================
  Files         154      154              
  Lines       13732    13717      -15     
==========================================
  Hits         7446     7446              
+ Misses       6286     6271      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marc2332]

I actually had a Link component some time ago, but the problem is that it didn't work well because Freya doesn't have events bubbling yet, I am waiting for the Dioxus 0.5 release. Once that is done, we should definitely merge this! I would call the component Link instead of Anchor, yes.

[tigerros]

I actually had a Link component some time ago, but the problem is that it didn't work well because Freya doesn't have events bubbling

We could add a label string prop like in ExternalLink instead of children then. Alternatively, add a warning about this issue.

[tigerros]

New things:

• Renamed Anchor to Link.
• Added the event propagation warning.
• Removed ExternalLink and added theming from it to Link.
• Migrated all references of ExternalLink to Link.

[tigerros]

New changes:

• Added ExternalLink back for situations without dioxus-router.
• Made the example better and it actually works (I didn't use dioxus-router previously).
• Updated, fixed, polished.

[marc2332]

Amazing work @tigerros ! I just resolved all the conflicts and cleaned some code, this LGTM. I would deprecate ExternalLink in this same PR, thoughts?

[tigerros]

Amazing work @tigerros ! I just resolved all the conflicts and cleaned some code, this LGTM. I would deprecate ExternalLink in this same PR, thoughts?

I don't think ExternalLink should be deprecated because Link only works with Dioxus's router and they do the same thing with external routes, with Link having some overhead.

[marc2332]

Amazing work @tigerros ! I just resolved all the conflicts and cleaned some code, this LGTM. I would deprecate ExternalLink in this same PR, thoughts?

I don't think ExternalLink should be deprecated because Link only works with Dioxus's router and they do the same thing with external routes, with Link having some overhead.

I can try to make Link work when dioxus-router is not being used, it shouldn't be that hard

[tigerros]

Amazing work @tigerros ! I just resolved all the conflicts and cleaned some code, this LGTM. I would deprecate ExternalLink in this same PR, thoughts?

I don't think ExternalLink should be deprecated because Link only works with Dioxus's router and they do the same thing with external routes, with Link having some overhead.

I can try to make Link work when dioxus-router is not being used, it shouldn't be that hard

Did something change with hooks? I thought you had to call them every time so you can't remove use_navigator.

[marc2332]

Amazing work @tigerros ! I just resolved all the conflicts and cleaned some code, this LGTM. I would deprecate ExternalLink in this same PR, thoughts?

I don't think ExternalLink should be deprecated because Link only works with Dioxus's router and they do the same thing with external routes, with Link having some overhead.

I can try to make Link work when dioxus-router is not being used, it shouldn't be that hard

Did something change with hooks? I thought you had to call them every time so you can't remove use_navigator.

Nothing changed, but I can get the navigator myself in L138 instead of using the hook:

let router = try_consume_context::<RouterContext>()
            .expect("Must be called in a descendant of a Router component");

router.push(to.clone());

[marc2332]

Just found a smalllllllllll bug with the events system in Freya, will open a PR later, after that, I will push some final touches and this PR will be ready to go

[marc2332]

works!

[marc2332]

I'll add some unit tests before merging

[marc2332]

Nice work @tigerros !