Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: VirtualScrollView simplification #478

Merged
merged 25 commits into from
Feb 10, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jan 26, 2024

Depends #268

  • No need to Box the builder
  • Simple caching of elements

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (590a0e0) 54.27% compared to head (204a2e4) 54.29%.
Report is 3 commits behind head on main.

Files Patch % Lines
...components/src/scroll_views/virtual_scroll_view.rs 0.00% 16 Missing ⚠️
crates/devtools/src/tabs/tree.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   54.27%   54.29%   +0.02%     
==========================================
  Files         154      155       +1     
  Lines       13540    13590      +50     
==========================================
+ Hits         7349     7379      +30     
- Misses       6191     6211      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 added this to the 0.2.0 milestone Jan 27, 2024
Base automatically changed from feat/event-bubbling to main February 6, 2024 21:33
@marc2332 marc2332 merged commit 9d3fbc2 into main Feb 10, 2024
7 checks passed
@marc2332 marc2332 deleted the feat/virtual-scroll-view-simplification branch February 10, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant