Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Input improvements #480

Merged
merged 21 commits into from
Feb 10, 2024
Merged

feat: Input improvements #480

merged 21 commits into from
Feb 10, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jan 27, 2024

Depends on #268

  • Enables keyboard focus for the Input
  • Changes the drop shadow
  • Moves the corner_radius to the Input Theme

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jan 27, 2024
@marc2332 marc2332 changed the title feat: Input improvements feat: Input improvements Jan 27, 2024
@marc2332 marc2332 mentioned this pull request Jan 27, 2024
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0bb9b29) 54.04% compared to head (3e58b63) 53.80%.
Report is 1 commits behind head on main.

❗ Current head 3e58b63 differs from pull request most recent head fe152c1. Consider uploading reports for the commit fe152c1 to get more accurate results

Files Patch % Lines
crates/components/src/input.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   54.04%   53.80%   -0.25%     
==========================================
  Files         153      152       -1     
  Lines       13398    13520     +122     
==========================================
+ Hits         7241     7274      +33     
- Misses       6157     6246      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 added this to the 0.2.0 milestone Jan 27, 2024
Base automatically changed from feat/event-bubbling to main February 6, 2024 21:33
@marc2332 marc2332 merged commit 048787f into main Feb 10, 2024
9 checks passed
@marc2332 marc2332 deleted the feat/input-improvements branch February 10, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant