Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simplify text measuring and rendering #486

Merged
merged 5 commits into from
Feb 10, 2024

Conversation

marc2332
Copy link
Owner

Depends on #346

@marc2332 marc2332 added enhancement 🔥 New feature or request layout 📐 Relate to layout labels Jan 30, 2024
Copy link

Benchmark for 0504bc9

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 30.1±0.35ms 31.3±0.62ms +3.99%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1586.6±18.18µs 1593.2±11.47µs +0.42%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 149.5±1.43µs 152.0±2.49µs +1.67%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 27.1±0.44ms 26.5±0.35ms -2.21%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.8±0.55ms 2.8±0.53ms 0.00%
benchmarks/size=19531 depth=7 wide=5 mode=cached 586.2±19.98µs 566.0±25.21µs -3.45%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.7±0.16ms 3.7±0.12ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 447.7±3.75µs 446.7±79.32µs -0.22%
benchmarks/size=54241 depth=5 wide=15 mode=cached 640.5±45.42µs 627.6±23.31µs -2.01%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.3±0.17ms 7.4±0.17ms +1.37%

Copy link

Benchmark for ad485fb

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 30.9±0.64ms 31.0±0.65ms +0.32%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1592.9±16.11µs 1609.3±37.99µs +1.03%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 149.1±1.05µs 152.1±9.95µs +2.01%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.6±0.25ms 25.9±0.21ms +1.17%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.8±0.57ms 2.7±0.52ms -3.57%
benchmarks/size=19531 depth=7 wide=5 mode=cached 561.1±22.16µs 551.0±27.93µs -1.80%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.7±0.20ms 3.5±0.12ms -5.41%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 435.8±26.11µs 445.2±68.02µs +2.16%
benchmarks/size=54241 depth=5 wide=15 mode=cached 639.9±23.24µs 630.3±37.49µs -1.50%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.3±0.29ms 7.3±0.18ms 0.00%

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0bb9b29) 54.04% compared to head (0fcfa2c) 53.86%.
Report is 3 commits behind head on main.

❗ Current head 0fcfa2c differs from pull request most recent head 52915df. Consider uploading reports for the commit 52915df to get more accurate results

Files Patch % Lines
crates/renderer/src/elements/label.rs 0.00% 4 Missing ⚠️
crates/core/src/layout/skia_measurer.rs 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   54.04%   53.86%   -0.18%     
==========================================
  Files         153      153              
  Lines       13398    13476      +78     
==========================================
+ Hits         7241     7259      +18     
- Misses       6157     6217      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 added this to the 0.2.0 milestone Feb 4, 2024
Base automatically changed from feat/updated-dioxus to main February 6, 2024 21:17
Copy link

github-actions bot commented Feb 8, 2024

Benchmark for 2247444

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 31.8±0.57ms 31.1±0.63ms -2.20%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1582.7±9.17µs 1619.3±41.99µs +2.31%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 149.9±1.18µs 151.4±1.78µs +1.00%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.9±0.28ms 26.0±0.19ms +0.39%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.8±0.64ms 2.8±0.60ms 0.00%
benchmarks/size=19531 depth=7 wide=5 mode=cached 516.2±19.00µs 578.4±64.06µs +12.05%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.5±0.12ms 3.7±0.44ms +5.71%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 445.5±38.78µs 440.1±20.18µs -1.21%
benchmarks/size=54241 depth=5 wide=15 mode=cached 682.1±38.78µs 642.8±44.81µs -5.76%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.6±0.39ms 7.3±0.09ms -3.95%

@marc2332 marc2332 merged commit 22831b1 into main Feb 10, 2024
7 checks passed
@marc2332 marc2332 deleted the feat/simplify-text-measuring-and-rendering branch February 10, 2024 14:16
Copy link

Benchmark for 6bdcd7f

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 30.8±0.27ms 30.6±0.80ms -0.65%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1589.2±7.44µs 1983.9±24.47µs +24.84%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 151.3±2.68µs 151.0±2.24µs -0.20%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.9±1.51ms 25.4±0.18ms -1.93%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.7±0.53ms 2.7±0.55ms 0.00%
benchmarks/size=19531 depth=7 wide=5 mode=cached 525.5±23.01µs 553.3±24.14µs +5.29%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.2±0.07ms 3.3±0.12ms +3.13%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 445.3±65.11µs 444.2±65.50µs -0.25%
benchmarks/size=54241 depth=5 wide=15 mode=cached 625.3±137.92µs 627.7±20.28µs +0.38%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.3±0.11ms 7.3±0.32ms 0.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement 🔥 New feature or request layout 📐 Relate to layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant