feat: flex support #920

marc2332 · 2024-09-25T12:24:53Z

Closes #327

github-actions · 2024-09-25T12:31:28Z

Benchmark for `5b0988e`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	103.3±0.50ms	106.4±3.23ms	+3.00%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.6±0.75ms	24.6±0.83ms	0.00%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1363.4±10.91µs	1420.2±50.99µs	+4.17%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	132.8±2.38µs	135.5±2.63µs	+2.03%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.1±0.58ms	24.2±0.75ms	+0.41%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1675.4±18.60µs	1719.8±14.84µs	+2.65%
benchmarks/size=19531 depth=7 wide=5 mode=cached	316.4±8.03µs	317.0±6.19µs	+0.19%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.6±0.05ms	2.6±0.05ms	0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	412.2±148.31µs	416.8±140.34µs	+1.12%
benchmarks/size=54241 depth=5 wide=15 mode=cached	270.4±140.43µs	257.1±20.95µs	-4.92%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.3±0.14ms	6.4±0.11ms	+1.59%

codecov · 2024-09-25T12:39:51Z

Codecov Report

Attention: Patch coverage is 95.16908% with 20 lines in your changes missing coverage. Please review.

Project coverage is 74.34%. Comparing base (b4be42b) to head (3dd519d).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/torin/src/measure.rs	87.20%	11 Missing ⚠️
crates/state/src/values/size.rs	25.00%	6 Missing ⚠️
crates/state/src/values/content.rs	0.00%	1 Missing ⚠️
crates/torin/src/values/content.rs	75.00%	1 Missing ⚠️
crates/torin/src/values/size.rs	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
+ Coverage   74.01%   74.34%   +0.33%     
==========================================
  Files         213      214       +1     
  Lines       24341    24739     +398     
==========================================
+ Hits        18015    18393     +378     
- Misses       6326     6346      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-25T20:37:27Z

Benchmark for `7ce5010`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	103.5±0.54ms	107.7±0.48ms	+4.06%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.1±1.03ms	25.9±1.47ms	+7.47%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1354.1±14.07µs	1430.3±45.54µs	+5.63%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	131.0±1.11µs	140.2±1.40µs	+7.02%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.1±0.63ms	25.2±0.80ms	+4.56%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1681.6±8.07µs	1751.7±9.87µs	+4.17%
benchmarks/size=19531 depth=7 wide=5 mode=cached	316.1±8.17µs	316.6±5.47µs	+0.16%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.6±0.02ms	2.7±0.02ms	+3.85%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	410.1±132.78µs	425.9±147.32µs	+3.85%
benchmarks/size=54241 depth=5 wide=15 mode=cached	281.1±12.43µs	253.2±12.26µs	-9.93%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.1±0.07ms	6.5±0.07ms	+6.56%

github-actions · 2024-09-28T15:17:52Z

Benchmark for `cfcef62`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	106.5±0.47ms	110.0±0.63ms	+3.29%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.8±0.69ms	25.5±0.99ms	+2.82%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1422.4±13.78µs	1491.9±16.02µs	+4.89%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	137.0±5.12µs	143.0±2.33µs	+4.38%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.2±0.53ms	24.8±0.40ms	+2.48%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1748.2±11.82µs	1803.9±16.95µs	+3.19%
benchmarks/size=19531 depth=7 wide=5 mode=cached	315.4±8.51µs	318.3±7.20µs	+0.92%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.6±0.02ms	2.8±0.03ms	+7.69%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	446.0±147.58µs	436.3±80.71µs	-2.17%
benchmarks/size=54241 depth=5 wide=15 mode=cached	252.3±20.22µs	256.4±16.16µs	+1.63%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.5±0.17ms	6.8±0.05ms	+4.62%

github-actions · 2024-09-30T12:50:01Z

Benchmark for `90883ac`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	109.4±0.80ms	109.6±0.53ms	+0.18%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	27.1±0.97ms	28.1±1.35ms	+3.69%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1439.6±56.95µs	1504.7±16.28µs	+4.52%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	137.7±3.72µs	144.7±1.61µs	+5.08%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	26.4±1.11ms	26.2±0.76ms	-0.76%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1812.2±66.59µs	1846.9±59.47µs	+1.91%
benchmarks/size=19531 depth=7 wide=5 mode=cached	340.0±26.31µs	353.1±25.15µs	+3.85%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.04ms	2.8±0.05ms	+3.70%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	447.0±178.58µs	431.0±4.84µs	-3.58%
benchmarks/size=54241 depth=5 wide=15 mode=cached	296.0±44.97µs	358.3±74.22µs	+21.05%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.6±0.17ms	7.1±0.43ms	+7.58%

github-actions · 2024-10-08T13:03:39Z

Benchmark for `a4596da`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	106.5±0.36ms	110.7±0.45ms	+3.94%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.6±0.88ms	26.1±1.70ms	+6.10%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1428.2±73.22µs	1473.2±16.39µs	+3.15%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	136.2±1.27µs	143.6±1.97µs	+5.43%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	23.9±0.45ms	24.9±0.56ms	+4.18%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1712.6±14.78µs	1801.2±31.50µs	+5.17%
benchmarks/size=19531 depth=7 wide=5 mode=cached	308.4±4.46µs	312.5±5.13µs	+1.33%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.6±0.02ms	2.7±0.01ms	+3.85%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	419.5±153.65µs	441.5±165.63µs	+5.24%
benchmarks/size=54241 depth=5 wide=15 mode=cached	263.7±30.69µs	246.8±17.49µs	-6.41%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.3±0.09ms	6.7±0.10ms	+6.35%

github-actions · 2024-10-08T13:24:41Z

Benchmark for `5e797cd`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	107.4±3.85ms	111.5±2.09ms	+3.82%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.5±1.48ms	24.7±1.20ms	+0.82%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1410.0±19.04µs	1461.4±27.76µs	+3.65%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	137.5±2.79µs	143.1±1.22µs	+4.07%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	25.5±1.95ms	27.2±2.30ms	+6.67%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1732.4±102.15µs	1790.5±39.40µs	+3.35%
benchmarks/size=19531 depth=7 wide=5 mode=cached	346.4±29.60µs	331.2±20.80µs	-4.39%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.6±0.03ms	2.9±0.15ms	+11.54%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	423.4±156.20µs	425.7±5.12µs	+0.54%
benchmarks/size=54241 depth=5 wide=15 mode=cached	249.8±16.76µs	299.1±45.47µs	+19.74%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.4±0.15ms	7.0±0.35ms	+9.38%

github-actions · 2024-10-13T15:44:42Z

Benchmark for `874d746`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	106.5±0.59ms	110.8±0.71ms	+4.04%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	27.8±0.70ms	28.2±1.31ms	+1.44%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1420.0±19.29µs	1529.7±115.49µs	+7.73%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	135.6±1.02µs	142.9±2.69µs	+5.38%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	26.9±1.70ms	27.0±1.56ms	+0.37%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	2.2±0.09ms	2.2±0.11ms	0.00%
benchmarks/size=19531 depth=7 wide=5 mode=cached	346.0±11.99µs	440.4±39.72µs	+27.28%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.6±0.03ms	3.1±0.32ms	+19.23%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	424.6±157.54µs	432.0±3.81µs	+1.74%
benchmarks/size=54241 depth=5 wide=15 mode=cached	271.5±21.78µs	414.2±53.50µs	+52.56%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.6±0.45ms	7.5±0.28ms	+13.64%

github-actions · 2024-11-01T17:09:22Z

Benchmark for `741c0fb`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	107.8±4.07ms	108.1±0.32ms	+0.28%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.2±0.90ms	25.8±1.46ms	+6.61%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1403.7±122.19µs	1480.1±12.22µs	+5.44%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	134.6±1.70µs	141.9±4.88µs	+5.42%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	23.8±0.30ms	24.2±1.21ms	+1.68%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1709.1±52.34µs	1761.3±7.58µs	+3.05%
benchmarks/size=19531 depth=7 wide=5 mode=cached	312.7±5.18µs	310.3±14.34µs	-0.77%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.07ms	2.7±0.15ms	0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	420.2±63.09µs	429.6±38.76µs	+2.24%
benchmarks/size=54241 depth=5 wide=15 mode=cached	242.6±20.36µs	240.4±19.97µs	-0.91%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.4±0.10ms	6.7±0.06ms	+4.69%

github-actions · 2024-11-01T17:43:52Z

Benchmark for `928d80e`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	105.9±0.92ms	109.9±0.85ms	+3.78%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	25.4±1.09ms	26.5±1.35ms	+4.33%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1406.2±19.02µs	1488.9±23.27µs	+5.88%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	136.6±1.74µs	143.4±1.95µs	+4.98%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.4±1.59ms	25.3±0.79ms	+3.69%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1748.9±114.68µs	1813.3±112.05µs	+3.68%
benchmarks/size=19531 depth=7 wide=5 mode=cached	334.5±39.02µs	319.6±18.73µs	-4.45%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.09ms	2.7±0.05ms	0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	422.2±153.70µs	439.3±154.15µs	+4.05%
benchmarks/size=54241 depth=5 wide=15 mode=cached	267.7±164.24µs	302.0±72.33µs	+12.81%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.4±0.19ms	6.9±0.48ms	+7.81%

github-actions · 2024-11-01T18:43:46Z

Benchmark for `05a99ab`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	106.9±0.85ms	108.4±2.01ms	+1.40%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	28.2±1.39ms	26.5±1.74ms	-6.03%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1580.5±9.58µs	1483.0±18.85µs	-6.17%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	152.0±2.88µs	141.3±1.51µs	-7.04%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	25.8±1.08ms	25.2±0.68ms	-2.33%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1752.4±87.39µs	1761.2±12.43µs	+0.50%
benchmarks/size=19531 depth=7 wide=5 mode=cached	319.3±18.33µs	309.9±5.00µs	-2.94%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.13ms	2.7±0.10ms	0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	421.9±84.59µs	431.4±132.16µs	+2.25%
benchmarks/size=54241 depth=5 wide=15 mode=cached	320.0±82.62µs	256.7±47.58µs	-19.78%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.5±0.30ms	7.0±0.69ms	+7.69%

feat: flex support

9b4d0cc

marc2332 added enhancement 🔥 New feature or request layout 📐 Relate to layout labels Sep 25, 2024

marc2332 mentioned this pull request Sep 25, 2024

rfc: flex implementation for rect #327

Closed

deno-deploy bot deployed to Preview September 25, 2024 12:26 View deployment

move flex to content

6a83d8e

deno-deploy bot deployed to Preview September 25, 2024 20:32 View deployment

Merge branch 'main' into feat/flex

e3278c6

deno-deploy bot deployed to Preview September 28, 2024 15:12 View deployment

Merge branch 'main' into feat/flex

2b6b818

deno-deploy bot deployed to Preview September 30, 2024 12:44 View deployment

Merge branch 'main' into feat/flex

b04de87

deno-deploy bot deployed to Preview October 8, 2024 12:58 View deployment

flex tests

531d14b

deno-deploy bot deployed to Preview October 8, 2024 13:18 View deployment

Merge branch 'main' into feat/flex

9ac867e

deno-deploy bot deployed to Preview October 13, 2024 15:38 View deployment

Merge branch 'main' into feat/flex

d25f2f3

deno-deploy bot deployed to Preview November 1, 2024 17:04 View deployment

flex docs

0b4cc7b

deno-deploy bot deployed to Preview November 1, 2024 17:38 View deployment

fmt

3dd519d

deno-deploy bot deployed to Preview November 1, 2024 18:38 View deployment

marc2332 marked this pull request as ready for review November 5, 2024 18:16

marc2332 merged commit 00ca902 into main Nov 10, 2024
8 checks passed

marc2332 deleted the feat/flex branch November 10, 2024 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: flex support #920

feat: flex support #920

marc2332 commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024

codecov bot commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 28, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Oct 8, 2024

github-actions bot commented Oct 8, 2024

github-actions bot commented Oct 13, 2024

github-actions bot commented Nov 1, 2024

github-actions bot commented Nov 1, 2024

github-actions bot commented Nov 1, 2024

feat: flex support #920

feat: flex support #920

Conversation

marc2332 commented Sep 25, 2024 • edited Loading

github-actions bot commented Sep 25, 2024

Benchmark for 5b0988e

codecov bot commented Sep 25, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 25, 2024

Benchmark for 7ce5010

github-actions bot commented Sep 28, 2024

Benchmark for cfcef62

github-actions bot commented Sep 30, 2024

Benchmark for 90883ac

github-actions bot commented Oct 8, 2024

Benchmark for a4596da

github-actions bot commented Oct 8, 2024

Benchmark for 5e797cd

github-actions bot commented Oct 13, 2024

Benchmark for 874d746

github-actions bot commented Nov 1, 2024

Benchmark for 741c0fb

github-actions bot commented Nov 1, 2024

Benchmark for 928d80e

github-actions bot commented Nov 1, 2024

Benchmark for 05a99ab

marc2332 commented Sep 25, 2024 •

edited

Loading

Benchmark for `5b0988e`

codecov bot commented Sep 25, 2024 •

edited

Loading

Benchmark for `7ce5010`

Benchmark for `cfcef62`

Benchmark for `90883ac`

Benchmark for `a4596da`

Benchmark for `5e797cd`

Benchmark for `874d746`

Benchmark for `741c0fb`

Benchmark for `928d80e`

Benchmark for `05a99ab`