-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefixes and parentheses to calc function #988
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #988 +/- ##
==========================================
- Coverage 74.34% 74.26% -0.09%
==========================================
Files 214 215 +1
Lines 24739 24644 -95
==========================================
- Hits 18393 18301 -92
+ Misses 6346 6343 -3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Co-authored-by: Marc Espin <[email protected]>
match prefix { | ||
DynamicCalculation::Add => lhs, | ||
DynamicCalculation::Sub => lhs.map(|v| v * -1.0), | ||
_ => unreachable!("make sure to add the prefix here"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean by this message, can this actually happen? if this can happen we should not be panicking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it cannot happen, if this happens it means the person adding a new prefix would have forgotten to handle it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for a second I thought I was going crazy but I think you forgot to handle parsing right? parse_calc
Added support for: