Team 3: Reader and Lexer #1
Conversation
|
Thanks ;) |
| @Override | ||
| public Token getToken() { | ||
|
|
||
| if (tokenText.isEmpty() && reader.isEOF()) { |
There was a problem hiding this comment.
All this logic should be moved to advance. All this method should do is to return the value of a member variable, that holds the current token.
| } | ||
|
|
||
| // read token chars | ||
| while (!reader.isEOF() && reader.getChar() != ' ' && reader.getChar() != '\n' && reader.getChar() != '\t') { |
There was a problem hiding this comment.
There is not always a whitespace between tokens. Think of parentheses, which are also tokens. This should also work if there is no whitespace.
What advance needs to do is, to match the input against all available state machines and the state machine, which can match the largest number of chars, gets to consume the input and create the respective token.
| } | ||
|
|
||
| private void advanceStringLiteral() { | ||
| do { |
There was a problem hiding this comment.
The StringLiteralStateMachine should do this part.
|
|
||
| @Override | ||
| public void close() throws IOException { | ||
| inputStream.close(); |
There was a problem hiding this comment.
Cool approach! This should close the input stream if anything exceptional occurs, right?
src/test/java/com/auberer/compilerdesignlectureproject/lexer/LexerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/auberer/compilerdesignlectureproject/lexer/LexerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/auberer/compilerdesignlectureproject/reader/ReaderTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/auberer/compilerdesignlectureproject/lexer/Lexer.java
Outdated
Show resolved
Hide resolved
marcauberer
changed the title
marcauberer
force-pushed
the
main
branch
6 times, most recently
from
b3aaf07
to
8e92f0a
Compare
No description provided.