This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
Team 6: Reader and Lexer #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcauberer
reviewed
Apr 17, 2024
| @Override | ||
| public Token getToken() { | ||
|
|
||
| if (tokenText.isEmpty() && reader.isEOF()) { |
There was a problem hiding this comment.
This logic should be part of advance. This method should only return the member variable that holds the current token.
| return null; | ||
| } | ||
|
|
||
| private void advanceStringLiteral() { |
There was a problem hiding this comment.
This is done by the StringLiteralStateMachine
| addState(start); | ||
| addState(end); | ||
|
|
||
| Range digits = new Range('0', '9'); |
There was a problem hiding this comment.
Please avoid accepting leading zeroes
| public void init() { | ||
| State stateStart = new State("Start"); | ||
| stateStart.setStartState(true); | ||
| stateStart.setAcceptState(true); |
There was a problem hiding this comment.
This looks suspicious. The accepting state shouldn't be the start state here.
| Reader reader = new Reader(new File("src/test/resources/test.txt")); | ||
| Lexer lexer = new Lexer(reader); | ||
|
|
||
| lexer.advance(); |
There was a problem hiding this comment.
Advance should be done automatically by expect, so you don't need to call both
| @Test | ||
| public void testGetChar() throws FileNotFoundException { | ||
| Reader reader = new Reader(testFile); | ||
| reader.getChar(); |
There was a problem hiding this comment.
Maybe you should assert somehow if the expectations afterwards are met
|
Tests should work though! |
marcauberer
force-pushed
the
main
branch
6 times, most recently
from
b3aaf07
to
8e92f0a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.