Abgabe Gruppe 8 #53

MargotGeisbauer · 2024-05-28T07:48:38Z

No description provided.

marcauberer

Tests are missing and coding needs to be improved before merging in your own interest.

marcauberer · 2024-05-28T14:51:16Z

src/main/java/com/auberer/compilerdesignlectureproject/sema/AtomicExprSymbolTable.java

+
+import java.util.Stack;
+
+public class AtomicExprSymbolTable extends SymbolTableBuilder{


Please do not create an own class, but use the SymbolTableBuilder class.

marcauberer · 2024-05-28T14:51:36Z

src/main/java/com/auberer/compilerdesignlectureproject/sema/AtomicExprSymbolTable.java

+    Stack<Scope> currentScopes = new Stack<>();
+
+    @Override
+    public Void visitEntry(ASTEntryNode node) {


Please use your own visit method, not visitEntry

marcauberer · 2024-05-28T14:52:23Z

src/main/java/com/auberer/compilerdesignlectureproject/sema/AtomicExprSymbolTable.java

+        visitChildren(node);
+
+
+        if (rootScope.lookupSymbol("identifier") == null)


You are always searching for "identifier" whenever a variable is referenced. This is not what should be done. Please fix.

marcauberer · 2024-05-28T14:52:57Z

src/main/java/com/auberer/compilerdesignlectureproject/sema/AtomicExprSymbolTable.java

+
+
+        if (rootScope.lookupSymbol("identifier") == null)
+            throw new SemaError("No identifier found");


Please print a better error message, that includes the name of the referenced variable

marcauberer · 2024-05-28T14:53:49Z

src/main/java/com/auberer/compilerdesignlectureproject/sema/AtomicExprSymbolTable.java

+
+    @Override
+    public Void visitEntry(ASTEntryNode node) {
+        Scope rootScope = new Scope();


You don't need any scopes-related boilerplate coding for your AtomicExprNode.

pull-request-size bot added the size/S label May 28, 2024

marcauberer suggested changes May 28, 2024

View reviewed changes

MargotGeisbauer closed this May 29, 2024

MargotGeisbauer force-pushed the main branch from bc9f465 to a2fefa3 Compare May 29, 2024 09:39

pull-request-size bot added size/XS and removed size/S labels May 29, 2024

Provide feedback


		import java.util.Stack;

		public class AtomicExprSymbolTable extends SymbolTableBuilder{

		visitChildren(node);


		if (rootScope.lookupSymbol("identifier") == null)



		if (rootScope.lookupSymbol("identifier") == null)
		throw new SemaError("No identifier found");