Skip to content
This repository has been archived by the owner on Jan 9, 2019. It is now read-only.

Support to compile from source as string and testcases to test the same #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arjunballa
Copy link

Support to compile from source as string and testcases to test the same

@cpopov
Copy link
Collaborator

cpopov commented Feb 28, 2013

Hello, can you explain what you are trying to achieve? Also there is problem with diff, I can'r see the differences on github, I bet it is due to unix/windows differences in new lines.

@arjunballa
Copy link
Author

I have added support to compile less from string source.
In my project we store the less source and imports in database as a blob and we need to dynamically compile less and serve.
To do this I modified to LessSource.java where all imports should be provided to public LessSource(String source, Map<String, LessSource> imports) constructor and also changed resolveImports method to look for imports in map.

I will submit a new pull request so that you can compare.

@arjunballa
Copy link
Author

Can you please export the eclipse Java Formatter profile and push that to github. I am using eclipse default format and there are lot of formatting differences.
My eclipse version is Helios Service Release 2

@cpopov
Copy link
Collaborator

cpopov commented Mar 1, 2013

I use intellij and Eclipe. You don't need the settings file. Don;t reformat the whole code, just your piece. Also I think your number of columns is 80. You can just increase that 120 or more.

@arjunballa
Copy link
Author

As the design is changed by introducing a new abstract class Resource this pull request is not valid anymore.
This pull request can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants