This repository has been archived by the owner on Jan 9, 2019. It is now read-only.
bug fix with absolute uri IMPORT #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exemple : @import "/less/styles_variables.less"; if the source file is not present into root directory
| File relativeFile; | ||
| if (relativePath.startsWith("/")) | ||
| { | ||
| relativeFile = new File(sourceDirectory, relativePath); |
There was a problem hiding this comment.
Is it backwards compatible, if the constructor is invoked without the sourceDirectory?
There was a problem hiding this comment.
Oups i missed a test condition for this case :( sorry
|
Thanks for the contribution @marcosemiao ! |
|
Hello, with many recurisve absolute path with import, there are bug, i fix it ;) |
|
Thanks for the good testing! |
|
Hello, You delivered two versions from my pull request since then April on the central maven repository, 1.7.0.1.0 and 1.7.0.1.1. Now I stand the 1.3.3 version with my patch on my project. Thanks ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exemple :
@import "/bootstrap/less/bootstrap.less";
if the source file is not present into root directory.
the compilation fail :
[ERROR] D:\dev\billetel\IRIS_14.03\modules\lotus\src\main\webapp\bordel\less\sty
les.less [0:0]: Error compiling LESS source
java.io.FileNotFoundException: File D:\dev\billetel\IRIS_14.03\modules\lotus\src
\main\webapp\bordel\less\bootstrap\less\bootstrap.less not found.
at org.lesscss.LessSource.(LessSource.java:59)
at org.lesscss.LessSource.resolveImports(LessSource.java:145)
at org.lesscss.LessSource.(LessSource.java:63)
at org.lesscss.mojo.CompileMojo.execute(CompileMojo.java:123)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(Default
BuildPluginManager.java:106)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor
.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor
.java:153)
the file "bootstrap.less" is not in "D:\dev\billetel\IRIS_14.03\modules\lotus\src
\main\webapp\bordel\less\bootstrap\less\bootstrap.less" but into D:\dev\billetel\IRIS_14.03\modules\lotus\src
\main\webapp\bordel\bootstrap\less\bootstrap.less"