Enable empty lists inferred as double (eg: <double>[]) to return a zero of type double #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the CI is failing but doesn't seem to be caused by the modified code.
What was the problem ?
When using sumBy on an empty list with a type inferred as
Iterable<double>
, the method throws an error.The error is :
Code in error :
Step to reproduce :
Reason :
If the list is empty, the for loop will not be entered and the return will do
return result as double;
howeverresult
equals 0 and has type int at runtime.Fix :
I propose to add an early return when the list is empty, we return either a zero from int or a zero from double depending on the type N is equal to. I had to create a small method that gets the expected zero since I did not find any better solution.