Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tick-sound period variable #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rsuhada
Copy link

@rsuhada rsuhada commented Oct 31, 2016

User can adjust how often the "tick" sound is played.
Default is org-pomodoro-tick-period 1: which is the current behavior: tick every second.

Setting e.g. org-pomodoro-tick-period to 5, will play the tick sound only every 5 second.

The change was implemented because ticking is an excellent feature, but every second was a bit too excessive to me. This way you can adjust how often you get the "pulse".

User can adjust how often the "tick" is played
@rsuhada
Copy link
Author

rsuhada commented Nov 2, 2016

Sorry - this was rushed and I thought I implemented the feature with a simple hack. Unfortunately the tick sound and the pomodoro state display are intertwined, which means that the solution in this pull request decreases the ticking frequency but also the countdown...

Sorry, please ignore this pull request.

@rsuhada rsuhada closed this Nov 2, 2016
@leoc leoc reopened this Nov 4, 2016
@leoc
Copy link
Collaborator

leoc commented Nov 4, 2016

Thanks for the idea! To accomplish what you are looking for you could change the function org-pomodoro-maybe-play-sound.

Since we are already counting the seconds within pomodoros & breaks, you could add a modulo check against the counter using your new custom variable.

Maybe you have time to refine your PR. I'd gladly merge! 👍

@rsuhada
Copy link
Author

rsuhada commented Nov 7, 2016

Thanks for the encouragement - I'll try to implement it when I have a bit of time (my elisp is rudimentary at best, but this should be a good exercise).

@marcinkoziej
Copy link
Owner

@rsuhada have you came up with something maybe?

@rsuhada
Copy link
Author

rsuhada commented Nov 9, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants