Skip to content

Commit

Permalink
Bug 1588815 [wpt PR 19703] - Fetch Metadata: deprecate `nested-naviga…
Browse files Browse the repository at this point in the history
…te` mode., a=testonly

Automatic update from web-platform-tests
Fetch Metadata: deprecate `nested-navigate` mode.

As discussed in
w3c/webappsec-fetch-metadata#45,

We have decided to shift the model around nested navigations from
exposure via the request's `mode` to its `destination`. This patch
shift the `nested-navigate` mode to two parts:
 - `navigate` for frame and iframe.
 - `no-cors` for object.

Change-Id: I09a2be6b41547f6eeb1e308416234a40f0c9b5b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862690
Commit-Queue: Yifan Luo <lyfgoogle.com>
Reviewed-by: Mike West <mkwstchromium.org>
Cr-Commit-Position: refs/heads/master{#709478}

--

wpt-commits: 2eebdd2f37758cdd94c0c2bddc70763862ef283f
wpt-pr: 19703

Differential Revision: https://phabricator.services.mozilla.com/D53477

UltraBlame original commit: 882f13426698c48ef98024c93a1a230427535bd0
  • Loading branch information
marco-c committed Nov 21, 2019
1 parent 680807f commit 3050a4d
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,36 +44,36 @@
create_test("{{host}}:{{ports[https][0]}}", FORCED, {
"site": "same-origin",
"user": "",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{hosts[][www]}}:{{ports[https][0]}}", FORCED, {
"site": "same-site",
"user": "",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{hosts[alt][www]}}:{{ports[https][0]}}", FORCED, {
"site": "cross-site",
"user": "",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{host}}:{{ports[https][0]}}", USER, {
"site": "same-origin",
"user": "?1",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{hosts[][www]}}:{{ports[https][0]}}", USER, {
"site": "same-site",
"user": "?1",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{hosts[alt][www]}}:{{ports[https][0]}}", USER, {
"site": "cross-site",
"user": "?1",
"mode": "nested-navigate"
"mode": "navigate"
});
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
assert_header_equals(e.data, {
"site": "cross-site",
"user": "",
"mode": "nested-navigate",
"mode": "navigate",
});
t.done();
}));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,18 @@
create_test("{{host}}:{{ports[https][0]}}", {
"site": "same-origin",
"user": "",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{hosts[][www]}}:{{ports[https][0]}}", {
"site": "same-site",
"user": "",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{hosts[alt][www]}}:{{ports[https][0]}}", {
"site": "cross-site",
"user": "",
"mode": "nested-navigate"
"mode": "navigate"
});
</script>

0 comments on commit 3050a4d

Please sign in to comment.