Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux datafiles and install target #40

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

JakobDev
Copy link
Contributor

@JakobDev JakobDev commented Jan 3, 2024

This PR adds a desktop file and a AppStream file for Linux. It also adds a install target for CMake.

You need the update the releases in the AppStream file before making a new Release.

Note. When using the install target, it will also install all files for the submodules.

@JakobDev JakobDev mentioned this pull request Jan 3, 2024
@marco-calautti
Copy link
Owner

This PR adds a desktop file and a AppStream file for Linux. It also adds a install target for CMake.

You need the update the releases in the AppStream file before making a new Release.

Thanks a lot!

Note. When using the install target, it will also install all files for the submodules.

Technically, if Delta Patcher is built using wxBUILD_SHARED=OFF, there is no need to install any of the submodules. The only runtime dependencies in this case should be libc and gtk3.

Copy link
Owner

@marco-calautti marco-calautti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please address my comments?

app/CMakeLists.txt Outdated Show resolved Hide resolved
app/CMakeLists.txt Outdated Show resolved Hide resolved
@marco-calautti
Copy link
Owner

marco-calautti commented Jan 3, 2024

Everything looks good to me. I will merge. Tomorrow I will prepare a new release.

@marco-calautti marco-calautti merged commit 3dfa5e7 into marco-calautti:master Jan 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants