Improve backup error handling #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added
Database.backup()method fails to verify that the result of the lastsqlite3_backup_stepisSQLITE_DONE. If an error occurs while creating the backup (e.g. some IO error), the result might not beSQLITE_DONE.This pull request adds this check and throws if the result is not
SQLITE_DONE. It also ensures that the backup process is ended and the database connection is closed if an error occurs at any point.However, I've not been able to actually make the backup fail, so I can't verify that the final check yields the correct error message.
Apologies for the oversight in the previous pull request.