Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-9255: Make aiprompt and marksheme prompt required #5

Merged

Conversation

PM84
Copy link
Contributor

@PM84 PM84 commented Jul 15, 2024

It makes perfect sense to assume that the input fields aiprompt and markscheme are required.

@marcusgreen
Copy link
Owner

marcusgreen commented Jul 15, 2024

You are right that aiprompt should be required, that was something I overlooked. However I do not think markscheme should be required because there will be people who do not want to use it at all (i.e. feedback by an AI is one thing but a mark is a step further). Additionally getting marking right can be a significant challenge, as I found out today when experimenting with a math problem. I was thinking of making the mark scheme to be hide able on a global level via settings.

If you agree with me I could accept the pull and then remove the required option for mark scheme in a later commit.

@marcusgreen
Copy link
Owner

Or perhaps I could make mark scheme to be required or not required based on a plugin settings switch?

@PM84
Copy link
Contributor Author

PM84 commented Jul 15, 2024

You're right... I will remove the markesheme requirement.

@marcusgreen
Copy link
Owner

marcusgreen commented Jul 15, 2024

Excellent

@PM84 PM84 force-pushed the MBS-9255_Make_form_fields_required branch from 2b45f09 to acc65e6 Compare July 15, 2024 20:44
@marcusgreen marcusgreen merged commit 1a9984b into marcusgreen:main Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants