Added support for more than one Bitlocker key per volume #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was finding that the script would enumerate more than one $KeyProtectorId and then fail to write to Entra ID (BackupToAAD-...) as the value was an array and not a single GUID. This update loops for each $KeyProtectorId and writes each one to Entra ID. Failing script if any one of the attempts fails. Script succeeds if ALL keys are uploaded
| foreach ($Key in $BitlockerKey) { | ||
|
|
||
| try { | ||
| BackupToAAD-BitLockerKeyProtector -MountPoint $BitlockerDrive -KeyProtectorId $Key #-ErrorAction SilentlyContinue |
There was a problem hiding this comment.
I would add -ErrorAction Stop to make sure the catch kicks in.
|
@brianreidc7 Doesn't this PR then fix #7? |
mardahl
approved these changes
Nov 7, 2023
|
Thanks man, thats good to know 🥰
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Baard Hermansen ***@***.***>
Sent: Tuesday, November 7, 2023 10:59:11 AM
To: mardahl/PSBucket ***@***.***>
Cc: Michael Mardahl ***@***.***>; Mention ***@***.***>
Subject: Re: [mardahl/PSBucket] Added support for more than one Bitlocker key per volume (PR #8)
Hi Michael @mardahl<https://github.com/mardahl>
Just a tip: If you add
Close #7<#7>
when approving a merge (PR), the corresponding issue will be closed and linked to this PR :)
—
Reply to this email directly, view it on GitHub<#8 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHJPEIG4SOQCM3HFR63N23YDIA67AVCNFSM6AAAAAA67NZT6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJYGE3TSMBWHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was finding that the script would enumerate more than one $KeyProtectorId and then fail to write to Entra ID (BackupToAAD-...) as the value was an array and not a single GUID.
This update loops for each $KeyProtectorId and writes each one to Entra ID. Failing script if any one of the attempts fails. Script succeeds if ALL keys are uploaded