Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix httpx._types.VerifyTypes type hint #33

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

ondrg
Copy link
Contributor

@ondrg ondrg commented Dec 6, 2024

httpx removes VerifyTypes in 0.28.0 (encode/httpx@8e36f2b)

Raises error:

aioxmlrpc/client.py:156: in ServerProxy
    context: Optional[httpx._types.VerifyTypes] = None,
E   AttributeError: module 'httpx._types' has no attribute 'VerifyTypes'

httpx removes `VerifyTypes` in 0.28.0 (encode/httpx@8e36f2b)
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (a04221b) to head (dfb0c00).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   97.29%   97.33%   +0.03%     
==========================================
  Files           2        2              
  Lines          74       75       +1     
==========================================
+ Hits           72       73       +1     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mardiros
Copy link
Owner

mardiros commented Dec 6, 2024

I should have release a version that freeze httpx to <0.28 until I fix that.

Thanks for the MR !

@mardiros mardiros merged commit ee75653 into mardiros:main Dec 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants