MDEV-31517 Wrong variable name in the configuration leads Galera to think SST/IST failed, at next restart will request a full SST #536
Conversation
think SST/IST failed, at next restart will request a full SST This patch fixes an unwanted behavior of a Galera cluster node when Server startup fails because of an error in configuration file: after the failure full SST is requested at the next Server startup even though full SST is not needed (MDEV-31517). If Server startup fails because of a configuration error, this patch ensures that Galera state of the failing node remains unchanged. This avoids full SST at the next Server restart. This fix consists of three patches for the following components: 1) Server, 2) WSREP library, 3) Galera.
|
Can one of the admins verify this patch? |
5 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
sql/mysqld.cc
Outdated
| mysqld_get_one_option))) { | ||
|
|
||
| #ifdef WITH_WSREP | ||
| #if 0 |
sql/mysqld.cc
Outdated
| if (ho_error == EXIT_UNKNOWN_VARIABLE) { | ||
| #endif | ||
| Wsrep_server_state::instance().disable_node_reset(); | ||
| #if 0 |
|
Removed unnecessary code as suggested. |
There was a problem hiding this comment.
Your testcase should not pass with current released Galera library so please add check for galera library (example included).
Furthermore, there is confict on wsrep-lib and I think you need to update wsrep-lib in this pr also again to point master, make sure commit is 195cc5801e53
| --source include/galera_cluster.inc | ||
| --source include/have_mariabackup.inc | ||
|
|
||
| # Suppress expected errors and warnings: |
There was a problem hiding this comment.
Add check for correct Galera library like this:
--echo # Make sure that the test is operating on the right version of galera library.
--let $galera_version=26.4.25
source ../wsrep/include/check_galera_version.inc;
Test case should not pass without this ?
This patch fixes an unwanted behavior of a Galera cluster node when Server startup fails because of an error in configuration file: after the failure full SST is requested at the next Server startup even though full SST is not needed (MDEV-31517).
If Server startup fails because of a configuration error, this patch ensures that Galera state of the failing node remains unchanged. This avoids full SST at the next Server restart.
This fix consists of three patches for the following components: