MDEV-34124: Make sequences work with streaming replication #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use shared key for sequence update certification - employ native replication's code to apply changes for sequences which handles all corner cases properly - fix the tests to allow more transactions using sequences to be accepted That way the sequence is always updated to the maximum value independent of the order of updates, and shared certification keys allow to improve acceptance ratio of concurrent transactions that use sequences. It's reflected in the test changes.
janlindstrom
requested changes
Oct 24, 2025
janlindstrom
left a comment
janlindstrom
left a comment
There was a problem hiding this comment.
SR fix looks good, I would hope more multi-master test cases especially cases where one of the nodes for some reason is killed or otherwise out of cluster.
Author
|
It will not work until https://jira.mariadb.org/browse/MDEV-32823 is fixed. Moreover, now sequence updates are eventually consistent, so even in case of rollback/crash, they will get in sync either when other replicas advance the sequence far enough or the node that went out of sync replicates new sequence update. In any case, it should be safe. |
Author
|
Actually, I think adding a test with the crash scenario is possible. I will look into that. |
As the binlog statement cache is only replicated with the last fragment, it's safe to pass zero offset instead of the stored log position, which is used only for the binlog transaction cache.
- extend galera_sequences_transaction test with streaming replication combinations (it demonstrates the exact results compared to the regular Wsrep replication) - remove MDEV-28971 test as it's not applicable after fixing the binlog statement cache replication with Wsrep
mariadb-DenisProtivensky
force-pushed
the
10.6-MDEV-34124-sr
branch
from
0dfca35 to
90aa05d
Compare
Author
|
Added sequences crash recovery test to #537. It's used for SR with combinations. |
Author
|
Sending upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the binlog statement cache is only replicated with the last
fragment, it's safe to pass zero offset instead of the stored
log position, which is used only for the binlog transaction cache.
combinations (it demonstrates the exact results compared to the regular
Wsrep replication)
statement cache replication with Wsrep
Based on #537