Fix: Preserve secret if rootPasswordSecretKeyRef is unset (#1148) #1168
Conversation
| } | ||
| return secret, nil | ||
| } | ||
| package builder |
There was a problem hiding this comment.
The changes displayed are a bit odd, why the whole file has been marked as replaced? The owner changes LGTM, but can we make only the changes needed? This will help building context based on history in the future.
There was a problem hiding this comment.
This is making the linting fail. Can we fix it?
| } | ||
| assert.Equal(t, tt.opts.Data, secret.Data) | ||
| assert.Equal(t, tt.opts.Key.Name, secret.Name) | ||
| assert.Equal(t, tt.opts.Key.Namespace, secret.Namespace) |
There was a problem hiding this comment.
Can we add an assertion here to verify that the secret has a controller reference? Basiscally, when tt.owner is set, we need to verify that the controllerutil.HasControllerReference is true. See:
https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/controller/controllerutil#HasControllerReference
| if err != nil { | ||
| t.Fatalf("unexpected error creating discovery: %v", err) | ||
| } | ||
| builder := newTestBuilder(discovery) |
There was a problem hiding this comment.
| builder := newTestBuilder(discovery) | |
| builder := newDefaultTestBuilder(t) |
This way you don't need to instanciate a discovery and the tests will run
Fixes #1148