Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitmodules #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update .gitmodules #12

wants to merge 1 commit into from

Conversation

jorgtied
Copy link

googletest seems to have changed from master to main. This breaks submodule initialization (at least for me)

googletest seems to have changed from `master` to `main`. This breaks submodule initialization (at least for me)
@snukky
Copy link
Member

snukky commented Mar 22, 2022

Thanks for reporting this. I think this change should not be needed for the current setup: third_party/googletest points to a specific commit 0fc5466, which still exists in the origin/HEAD - the default branch if none specified. I couldn't reproduce the issue with the current marian-dev using git 2.25.1. Did you update the submodule manually or use a marian fork that may have different setup of submodules?

@jorgtied
Copy link
Author

OK - good to know. I have marian-dev as a sub-module in one of my projects and I got a problem for some strange reason. I need to check what happened there. Thanks for taking the time to check it ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants