refacto: revert Unix.sleepf to Eio time module #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilou97
force-pushed
the
reintroduce-eio-time-sleep
branch
2 times, most recently
from
af6557c
to
f870dab
Compare
Pilou97
force-pushed
the
reintroduce-eio-time-sleep
branch
from
f870dab
to
b0f36b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Eio.TIme.sleep_until was removed because it introduced a bug (invokation/origination wasn't possible)
It was replaced by Unix.sleepf ,but this sleep, sleep all the domain
Solution
Reintroduce Eio.Time.sleep at a better place
I've added a chain action
Chain_sleep of {duration: float}and replace theFiber.List.iterto another solution to allow forking or not according to the actionTests
The origination/invokation of a smart contract is still working
The stats endpoint shows correct statistics