Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP new contracts #37

Draft
wants to merge 7 commits into
base: staging
Choose a base branch
from
Draft

WIP new contracts #37

wants to merge 7 commits into from

Conversation

aguillon
Copy link
Collaborator

@aguillon aguillon commented Jan 4, 2024

I don't think it's worth merging this, but please take a quick look.

This is based on aguillon/permit-cameligo#3 ; please make sure you understand how it works and ask questions if you have any.

I would suggest, however, that we remove demo/ from this repository, as well as the two contracts staking-contract and permit-cameligo:

  1. we're not using it anymore (the actual demo is live, and we're using the TypeScript example to test it/present the GS);
  2. thus, we're not updating it and we're never sure it works with the current version of the API (it probably doesn't);
  3. the given contracts are not necessary to use the Gas Station; again, they're just here for the demo.

What do you think would be the best way to replace them?

@quentin-burg
Copy link
Collaborator

I agree with you !
But we need to keep the code somewhere if we need to update it. But I don't know where we can put it. Maybe a fresh repo with the two contracts and a notebook ? 🤷‍♂️

And why did you say that contracts didn't work with the current version of our API ? 🧐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants