Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DST-110]: Share Field Styles across multiple Components #3248

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

OsamaAbdellateef
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 7:09am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 7:09am

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #3248 (45287ae) into main (9861b88) will not change coverage.
Report is 7 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #3248   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          112       112           
  Lines         7088      7088           
  Branches       319       319           
=========================================
  Hits          7088      7088           

@OsamaAbdellateef OsamaAbdellateef marked this pull request as ready for review August 3, 2023 12:58
@sarahgm
Copy link
Member

sarahgm commented Aug 4, 2023

what is with the other form components? Isn't it also possible? @OsamaAbdellateef

@OsamaAbdellateef
Copy link
Contributor Author

what is with the other form components? Isn't it also possible? @OsamaAbdellateef

what is with the other form components? Isn't it also possible? @OsamaAbdellateef
@sarahgm
like what ?

@sarahgm
Copy link
Member

sarahgm commented Aug 4, 2023

what is with the other form components? Isn't it also possible? @OsamaAbdellateef

what is with the other form components? Isn't it also possible? @OsamaAbdellateef
@sarahgm
like what ?

to use the styles? DateField, TextField and so on :D I was just wondering @OsamaAbdellateef

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

⚠️ No Changeset found

Latest commit: 45287ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OsamaAbdellateef
Copy link
Contributor Author

what is with the other form components? Isn't it also possible? @OsamaAbdellateef

what is with the other form components? Isn't it also possible? @OsamaAbdellateef
@sarahgm
like what ?

to use the styles? DateField, TextField and so on :D I was just wondering @OsamaAbdellateef

@sarahgm
Yeah most of them are unified because they use the same Input component but not all of them, and i added styles for components that aren't using Input

@sarahgm sarahgm merged commit 306a97f into main Aug 7, 2023
13 checks passed
@sarahgm sarahgm deleted the unify-field-styles branch August 7, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants