Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test shiki update #3808

Closed
wants to merge 22 commits into from
Closed

test shiki update #3808

wants to merge 22 commits into from

Conversation

sarahgm
Copy link
Member

@sarahgm sarahgm commented Mar 7, 2024

No description provided.

Copy link

changeset-bot bot commented Mar 7, 2024

⚠️ No Changeset found

Latest commit: 514f379

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ❌ Failed (Inspect) Mar 14, 2024 8:23am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 8:23am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 8:23am

@sarahgm
Copy link
Member Author

sarahgm commented Mar 7, 2024

vercel/next.js#58576

@sarahgm
Copy link
Member Author

sarahgm commented Mar 11, 2024

Thing that isn't working is: the demos are undefined. @aromko and I tried to solve it, but we haven't a good idea why it is like this. If you want to you can also try to solve it. @OsamaAbdellateef @sebald

@sebald
Copy link
Member

sebald commented Mar 11, 2024

Maybe something for mob?

@sarahgm
Copy link
Member Author

sarahgm commented Mar 12, 2024

@sarahgm
Copy link
Member Author

sarahgm commented Mar 12, 2024

docs
├─┬ contentlayer 0.3.4
│ └─┬ @contentlayer/cli 0.3.4
│ └─┬ @contentlayer/core 0.3.4
│ ├── ✕ unmet peer esbuild@"0.17.x || 0.18.x": found 0.19.10
│ └─┬ @contentlayer/utils 0.3.4
│ └─┬ @opentelemetry/exporter-trace-otlp-grpc 0.39.1
│ ├─┬ @opentelemetry/core 1.13.0
│ │ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.5.0": found 1.7.0 in @contentlayer/utils
│ └─┬ @opentelemetry/otlp-transformer 0.39.1
│ ├── ✕ unmet peer @opentelemetry/api@">=1.3.0 <1.5.0": found 1.7.0 in @contentlayer/utils
│ ├─┬ @opentelemetry/resources 1.13.0
│ │ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.5.0": found 1.7.0 in @contentlayer/utils
│ ├─┬ @opentelemetry/sdk-logs 0.39.1
│ │ └── ✕ unmet peer @opentelemetry/api@">=1.4.0 <1.5.0": found 1.7.0 in @contentlayer/utils
│ ├─┬ @opentelemetry/sdk-metrics 1.13.0
│ │ └── ✕ unmet peer @opentelemetry/api@">=1.3.0 <1.5.0": found 1.7.0 in @contentlayer/utils
│ └─┬ @opentelemetry/sdk-trace-base 1.13.0
│ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.5.0": found 1.7.0 in @contentlayer/utils
└─┬ next-contentlayer 0.3.4
└── ✕ unmet peer next@"^12 || ^13": found 14.1.2

Done in 36s

@sarahgm
Copy link
Member Author

sarahgm commented Mar 12, 2024

docs
├─┬ contentlayer 0.3.4
│ └─┬ @contentlayer/cli 0.3.4
│ └─┬ @contentlayer/core 0.3.4
│ ├── ✕ unmet peer esbuild@"0.17.x || 0.18.x": found 0.19.10
│ └─┬ @contentlayer/utils 0.3.4
│ └─┬ @opentelemetry/exporter-trace-otlp-grpc 0.39.1
│ ├─┬ @opentelemetry/core 1.13.0
│ │ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.5.0": found 1.7.0 in @contentlayer/utils
│ └─┬ @opentelemetry/otlp-transformer 0.39.1
│ ├── ✕ unmet peer @opentelemetry/api@">=1.3.0 <1.5.0": found 1.7.0 in @contentlayer/utils
│ ├─┬ @opentelemetry/resources 1.13.0
│ │ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.5.0": found 1.7.0 in @contentlayer/utils
│ ├─┬ @opentelemetry/sdk-logs 0.39.1
│ │ └── ✕ unmet peer @opentelemetry/api@">=1.4.0 <1.5.0": found 1.7.0 in @contentlayer/utils
│ ├─┬ @opentelemetry/sdk-metrics 1.13.0
│ │ └── ✕ unmet peer @opentelemetry/api@">=1.3.0 <1.5.0": found 1.7.0 in @contentlayer/utils
│ └─┬ @opentelemetry/sdk-trace-base 1.13.0
│ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.5.0": found 1.7.0 in @contentlayer/utils
└─┬ next-contentlayer 0.3.4
└── ✕ unmet peer next@"^12 || ^13": found 14.1.2

Done in 36s

tried to solve it adding this in the package.json:
"overrides": { "next-contentlayer": { "next": "$next" }, "contentlayer": { "esbuild@": "0.18.x" } },

@sarahgm
Copy link
Member Author

sarahgm commented Mar 12, 2024

running: pnpm contentlayer build => TypeError: The "code" argument must be of type number. Received an instance of Object :S

@sarahgm
Copy link
Member Author

sarahgm commented Mar 13, 2024

@aromko
Copy link
Contributor

aromko commented Mar 14, 2024

Important

It seems like this is an issue with contentlayer as long there is no way to update it updating rehype plugins might not work. We wait if the project ist picked up again, if not we have to find an alternative. See contentlayerdev/contentlayer#429.
Possible alternative: https://www.mdxts.dev/

@aromko aromko closed this Mar 14, 2024
@sarahgm sarahgm deleted the test-shiki-and-plugin branch October 25, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants