Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add close button on <SectionMessage> #4204

Merged
merged 18 commits into from
Oct 18, 2024

Conversation

sarahgm
Copy link
Member

@sarahgm sarahgm commented Oct 8, 2024

Description

  • Revised the <SectionMessage> page according to our new component pages.
  • While revising adding a close button to align the component with our feedback messages pattern.

What should be tested?

  • if the close button closes
  • if the new docs are understandable

Reviewers

@marigold-ui/developer
@marigold-ui/designer

closes DST-582

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 23fed5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@marigold/docs Patch
@marigold/components Patch
@marigold/theme-b2b Patch
@marigold/theme-core Patch
@marigold/storybook-config Patch
@marigold/theme-docs Patch
@marigold/system Patch
@marigold/icons Patch
@marigold/theme-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 7 resolved Oct 18, 2024 0:36am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 0:36am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 0:36am

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
99.24% (-0.06% 🔻)
7940/8001
🟢 Branches
90.57% (-0.47% 🔻)
365/403
🟢 Functions
98.5% (+0.01% 🔼)
131/133
🟢 Lines
99.24% (-0.06% 🔻)
7940/8001
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / Checkbox.tsx
98.48% (-1.52% 🔻)
91.67% (+7.05% 🔼)
100%
98.48% (-1.52% 🔻)
🟢
... / HelpText.tsx
97.83% (-2.17% 🔻)
76.92% (-23.08% 🔻)
100%
97.83% (-2.17% 🔻)

Test suite run success

574 tests passing in 78 suites.

Report generated by 🧪jest coverage report action from 23fed5e

@sarahgm sarahgm marked this pull request as ready for review October 10, 2024 13:29
@sarahgm sarahgm changed the title docs: revise SectionMessage page | add dismiss button docs([DST-582]): revise SectionMessage page | add dismiss button Oct 10, 2024
@sarahgm sarahgm changed the title docs([DST-582]): revise SectionMessage page | add dismiss button docs([DST-582]): revise <SectionMessage page> | feat(components): add close button on <SectionMessage> Oct 10, 2024
@sebald
Copy link
Member

sebald commented Oct 18, 2024

I would not have 2 things in the headline, just having the feat here. Adding docs should be obvious and it is enought to have it in the PR description.

@sarahgm sarahgm changed the title docs([DST-582]): revise <SectionMessage page> | feat(components): add close button on <SectionMessage> feat(components): add close button on <SectionMessage> Oct 18, 2024
@sebald sebald merged commit f6a132c into main Oct 18, 2024
15 checks passed
@sebald sebald deleted the revise-section-message-page branch October 18, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants