Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Text): Only apply elementType when RAC Text component is used. #4270

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

sebald
Copy link
Member

@sebald sebald commented Oct 29, 2024

Description

Removes this warning:

Warning: React does not recognize the `elementType` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `elementtype` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

Reviewers:

@marigold-ui/developer

Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: daf9568

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@marigold/components Patch
@marigold/storybook-config Patch
@marigold/docs Patch
@marigold/theme-b2b Patch
@marigold/theme-core Patch
@marigold/theme-docs Patch
@marigold/system Patch
@marigold/icons Patch
@marigold/theme-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 5:47pm
marigold-storybook 🛑 Canceled (Inspect) Oct 29, 2024 5:47pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 5:47pm

@github-actions github-actions bot added the type:feature New feature or component label Oct 29, 2024
Copy link
Contributor

github-actions bot commented Oct 29, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
99.27% (+0.02% 🔼)
8026/8085
🟢 Branches
90.1% (-0.52% 🔻)
364/404
🟢 Functions 99.24% 130/131
🟢 Lines
99.27% (+0.02% 🔼)
8026/8085
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / Checkbox.tsx
100% (+1.52% 🔼)
84.62% (-7.05% 🔻)
100%
100% (+1.52% 🔼)
🟢
... / Input.tsx
98.72% (-1.28% 🔻)
80% (-20% 🔻)
100%
98.72% (-1.28% 🔻)

Test suite run success

576 tests passing in 78 suites.

Report generated by 🧪jest coverage report action from daf9568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants