-
Notifications
You must be signed in to change notification settings - Fork 692
improvement: add completion info to SQL table completions #6502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ad47aa8
to
5116d48
Compare
"name", | ||
"email", | ||
], | ||
"children": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these snapshots changed for two reason:
- instead of just labels, it now includes a custom Completion with a
info
render - We also include default databases at the top (previously did not). that can be see in this commit: 780202d#diff-f79af3635ef377d486695e4101902aad0982c208b769b3851c9086e694f722f3
|
||
// Otherwise, we need to use the fully qualified name | ||
for (const database of connection.databases) { | ||
if (database.name === defaultDb?.name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only functional change. we now include the default db which can help with autocomplete or if users want fully qualified names
Yep, i already made these changes to codemirror-sql, so we can use them when we upgrade |
This adds a completion info (unstyled for now) to the table completion.
Also
SQLNamespace
More images