Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sessionID created by createSessionID() #46

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

mario-bermonti
Copy link
Owner

Description

Creating a session id using createSessionID() was improved by

  • fixing an error by now converting the DateTime.now() object to string before concatenating it to the participant id
  • defining the startTime inside the createSessionID(). Doesn't require the caller to pass data that is easy to get by the function and that won't change
  • using the format [participantID]_[startTime] to make the session id more readable.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🐞 Bug fix (non-breaking change that fixes an issue)
  • 🔧 Maintenance (non-breaking change that improves code)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix
  • 🔐 Improvements to the CI workflow

Checklist

Sorry, something went wrong.

refactor: Calculate startTime in createSessionID()

refactor: Don't pass startTime to createSessionID()
@mario-bermonti mario-bermonti merged commit 81b8f12 into mario-bermonti/issue42 Mar 6, 2024
2 checks passed
@mario-bermonti mario-bermonti deleted the fix-sessionID branch March 6, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant