Skip to content

Commit

Permalink
Backport1922 (ansible-collections#1928)
Browse files Browse the repository at this point in the history
Backport1922

SUMMARY
Use include_tasks instead of include in the integration tests.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
vmware_category
vmware_host_auto_start
vmware_object_rename
vmware_tag
vmware_tag_info
vmware_tag_manager
ADDITIONAL INFORMATION
Backport ansible-collections#1922
  • Loading branch information
mariolenz authored Nov 15, 2023
1 parent f2c8f29 commit d39400d
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 10 deletions.
2 changes: 1 addition & 1 deletion tests/integration/targets/vmware_category/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@

- import_role:
name: prepare_vmware_tests
- include: associable_obj_types.yml
- include_tasks: associable_obj_types.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
with_items: ['test_vm1', 'test_vm2']

- include_tasks: reset_auto_start_config.yml
- include: vcenter_auto_start_ops.yml
- include_tasks: vcenter_auto_start_ops.yml
- include_tasks: reset_auto_start_config.yml
- include: esxi_auto_start_ops.yml
- include_tasks: esxi_auto_start_ops.yml
always:
- include_tasks: reset_auto_start_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# Copyright: (c) 2019, Abhijeet Kasurde <[email protected]>
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

- include: dc_rename.yml
- include_tasks: dc_rename.yml
6 changes: 3 additions & 3 deletions tests/integration/targets/vmware_tag/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
# Copyright: (c) 2019, Pavan Bidkar <[email protected]>
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

- include: tag_crud_ops.yml
- include: tag_manager_ops.yml
- include: tag_manager_duplicate_tag_cat.yml
- include_tasks: tag_crud_ops.yml
- include_tasks: tag_manager_ops.yml
- include_tasks: tag_manager_duplicate_tag_cat.yml
2 changes: 1 addition & 1 deletion tests/integration/targets/vmware_tag_info/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# Copyright: (c) 2020, Abhijeet Kasurde <[email protected]>
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

- include: tag_info.yml
- include_tasks: tag_info.yml
4 changes: 2 additions & 2 deletions tests/integration/targets/vmware_tag_manager/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@
- name: Set category one id
set_fact: cat_one_id={{ category_one_create['category_results']['category_id'] }}

- include: tag_manager_dict.yml
- include_tasks: tag_manager_dict.yml
always:
- include: cleanup.yml
- include_tasks: cleanup.yml
5 changes: 5 additions & 0 deletions tests/sanity/ignore-2.17.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
plugins/modules/vmware_deploy_ovf.py replace-urlopen!skip
plugins/modules/vmware_deploy_ovf.py use-argspec-type-path!skip
plugins/modules/vmware_host_acceptance.py validate-modules:parameter-state-invalid-choice
scripts/inventory/vmware_inventory.py pep8!skip
tests/unit/mock/loader.py pep8!skip

0 comments on commit d39400d

Please sign in to comment.