Add sw-precache #470
Add sw-precache #470
Conversation
|
This PR is ready for review. Before merging it we need to solve #454 (moving on https). |
|
Closing this until we can find solution for using HTTPS. |
|
Reopening that due to #469. I'll resolve and retest stuff later... |
|
For this we'll want to do something to redirect people to https:// right? Like currently either http:// or https:// works. |
add hash for assets using grunt improve adding aliases for assets polish stuff update readme
|
I've updated stuff. Also added some improvements. So right now we have 88% score for Lighthouse
To reach 100% we have to solve - #495 |
|
Since @thejameskyle added redirect to |
|
💥 +1 |
| @@ -1,4 +1,4 @@ | |||
| input.hidden-visually(type="checkbox", id="toggle-search") | |||
| input.hidden-visually(type="checkbox", id="toggle-search", hidden) | |||
There was a problem hiding this comment.
Is this really intended? The hidden attr will prevent that element from rendering - not only from showing to user. The element is indented to be rendered by browser, only by added .hidden-visually is intended to be not shown on the screen (but it still rendered for screen reader or content scanner)
There was a problem hiding this comment.
@peterblazejewicz yeap you are right 👍 I have to recheck if this stuff https://github.com/marionettejs/marionettejs.com/blob/master/src/js/search.js#L6 will work though.
Related to #469