Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.09.13 - WIP #23

Merged
merged 10 commits into from
Sep 25, 2023
Merged

Conversation

corbin-c
Copy link

Pull request

Description

This PR starts the refactoring of the huge 'index.js' file, by extracting methods into separate modules.

Issues closed

Please note this is just the beginning so for now it doesn't fix anything.

Did you test it locally?

  • I tested it on a local environment and it works. I couldn't fully test though, since I don't have a Mac at hand.

Checklist

  • My code follows the style guidelines of this project -> couldn't find them
  • I have performed a self-review of my own document
  • I updated the change log file linking to the relevant sections -> couldn't find it
  • My changes generate no new warnings
  • I have checked corrected any misspellings

@markbattistella markbattistella marked this pull request as ready for review September 25, 2023 01:31
Copy link
Owner

@markbattistella markbattistella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for modularisation.

@markbattistella markbattistella merged commit 7f39263 into markbattistella:2023.09.13 Sep 25, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants