Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-12-05 - Change PhraseGenerator from public to open #37

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

manicmachine
Copy link
Contributor

Pull Request

Important

Please ensure you have named your pull request with the proper naming convention. This is usually in the YYYY-MM-DD - format. This aids in maintaining the codebase in a consistent and uniform format.

Description

Related Issues

Fixes an issue where users can't inherit PhraseGenerator due to it being public and not open.

Local Testing

  • [ ✓ ] I have tested these changes on a local environment and confirm they work as expected.

Checklist

  • [ ✓ ] My changes generate no new warnings or errors.
  • [ ✓ ] I have performed a self-review of my own code/documentation.
  • [ ✓ ] I have updated the change log file (if applicable), linking to the relevant sections.
  • [ ✓ ] I have checked and corrected any mis-spellings and grammatical errors.
  • [ ✓ ] I have ensured that any dependencies are updated and documented.
  • [ ✓ ] I have included relevant unit tests and they pass.
  • [ ✓ ] I have added or updated documentation as needed.

Additional Notes

Minor change, but can't inherit PhraseGenerator and implement my own generator without it.

@markbattistella markbattistella merged commit 9f92992 into markbattistella:main Dec 6, 2024
1 check passed
@markbattistella
Copy link
Owner

Added into 1.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants