Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url not matched when it contains ...: #100

Open
Bilb opened this issue Jan 26, 2022 · 3 comments
Open

url not matched when it contains ...: #100

Bilb opened this issue Jan 26, 2022 · 3 comments

Comments

@Bilb
Copy link

Bilb commented Jan 26, 2022

Hey,

First, thanks for the amazing library!
This is linked to #66 I assume but I cannot make this URL be matched by linkify
https://odysee.com/@spacebusters:c9/It's-beginning-to-look...:1
But without the semicolon it works:
https://odysee.com/@spacebusters:c9/It's-beginning-to-look...1

and with the semicolon and not the triple dots, it works too
https://odysee.com/@spacebusters:c9/It's-beginning-to-look:1

Any luck you can add ...: to the allowed match?

Thanks a lot

@puzrin
Copy link
Member

puzrin commented Jan 27, 2022

Any luck you can add ...: to the allowed match?

Need more strict rule because phrase like link...: foo bar will cause false positive. Please provide more samples.

  • It's important to understand, what can follow after : in your case. Multiple real samples required.
  • Your existing sample does not work (makes redirect). I'd prefer real link.

I do not reject, but any change starts with info collection to investigate patterns more deep. In euristic algorythms any "special case" should be as narrow as possible.

@KeeJef
Copy link

KeeJef commented Aug 25, 2023

Need more strict rule because phrase like link...: foo bar will cause false positive. Please provide more samples.

  • It's important to understand, what can follow after : in your case. Multiple real samples required.
  • Your existing sample does not work (makes redirect). I'd prefer real link.

I do not reject, but any change starts with info collection to investigate patterns more deep. In euristic algorythms any "special case" should be as narrow as possible.

Seems the examples i can find are all Odysee links, some examples here

(Here the video title is "It's-beginning-to-look..." and Odysee encodes this title into their URL)
https://odysee.com/@spacebusters:c9/It's-beginning-to-look...:1

Heres a few more Odysee links which are correctly detected

https://odysee.com/@AlphaNerd:8/i-built-an-online-store:1
https://odysee.com/@AlphaNerd:8/elon-musk's-twitter-rebrand-is:c
https://odysee.com/@AlphaNerd:8/a-p2p-chicken-feed-and-compost-system:3

Seems that Odysee will put a letter or number after the colon, not sure what significance this has

@edisondotme
Copy link

Came to file this bug report. Interesting that everyone gets here because of Odysee links, which is the same for me.
https://odysee.com/@SydneyWatson:a/the-parody-of-motherhood-continues...:4 gets shortened to:
https://odysee.com/@SydneyWatson:a/the-parody-of-motherhood-continues on desktop for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants