Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Symfony 4.4 #381

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented May 13, 2024

Symfony 4.4 is EOL, so just as the title says, this drops support for the legacy branch.

@mbabker mbabker force-pushed the drop-sf-44 branch 2 times, most recently from a0e4f06 to 6b151bf Compare May 13, 2024 17:31
@okorneliuk
Copy link

okorneliuk commented Jun 14, 2024

@mbabker please, drop 6.0 - 6.3 as well, because these versions are also EOL. Please, add 7.1 to the matrix.

Also, CI doesn't like this:

use Symfony\Component\Security\Http\RememberMe\RememberMeHandlerInterface;

@mbabker
Copy link
Contributor Author

mbabker commented Jun 14, 2024

please, drop 6.0 - 6.3 as well, because these versions are also EOL. Please, add 7.1 to the matrix.

Neither of these changes is related to this pull request. Also, from a practical perspective, dropping the 6.0-6.3 releases doesn't change anything meaningful in the code given that 5.4 is still supported (the only thing it does is get rid of a few CI builds). On the other hand, dropping 4.4 support allows removing some B/C-related code.

Also, CI doesn't like this:

The CS issue is fixed.

@okorneliuk
Copy link

@mbabker You are right, these changes are not related to the current title of the PR. However, it would be convenient to reorder versions once, because after this change, major version of the bundle should be bumped according to SemVer. Another dropping will cause another bump, but as you mentioned, dropping of 6.0-6.3 is not so significant. You can edit the title of the PR to reflect all changes you've made.
If you are still against doing these changes here, I will likely create a new PR. Thank you for your contribution 👍

@mbabker
Copy link
Contributor Author

mbabker commented Jun 14, 2024

However, it would be convenient to reorder versions once, because after this change, major version of the bundle should be bumped according to SemVer.

Dropping support for Symfony 4.4 does not require a SemVer major release, the API of this bundle has not changed, and a package manager will properly restrict updates on unsupported environments. As a convenience, many package maintainers will not drop support for environments without a major version release, but this is not a hard requirement.

The pull request title and description are accurate for the focus of this pull request. Further pull requests can target other changes, but lumping unrelated changes together in a single pull request just makes review more complicated (i.e. how does adding a test build for Symfony 7.1, and addressing potential deprecations that are found from that, relate to dropping support for Symfony 4.4?).

@markitosgv markitosgv merged commit a47a373 into markitosgv:master Nov 23, 2024
25 checks passed
@mbabker mbabker deleted the drop-sf-44 branch November 23, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants