Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request headers into route context #4

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Add request headers into route context #4

merged 1 commit into from
Nov 20, 2019

Conversation

cegerard
Copy link
Contributor

@cegerard cegerard commented Nov 3, 2019

This will allow developpers to get custom headers or cookies.
For instance it is usefull for authentication purpose.

This will allow developpers to get custom headers or cookies.
For instance it is usefull for authentication purpose.
@jsf-clabot
Copy link

jsf-clabot commented Nov 3, 2019

CLA assistant check
All committers have signed the CLA.

@cegerard
Copy link
Contributor Author

Hi, @austinkelleher, @philidem is there anyone that maintains this project ?

@austinkelleher
Copy link
Collaborator

@cegerard Sorry for late reply. Thanks for the reminder!

I appreciate you taking the time to open this PR. I'm wondering if this old PR should be merged instead: #1

What do you think? Would you rather see the rest.req.headers object exposed or the entire rest.req exposed?

/cc @mlrawlings @DylanPiercey

@cegerard
Copy link
Contributor Author

Thank for the reply @austinkelleher
IMHO we don't need the full request object or if it is the case perhaps it will be more interesting to move to other solutions (express., etc.).

This modification is related to this PR marko-js-archive/marko-starter#41.

I personally prefer to keep thing as simple as possible.

@austinkelleher
Copy link
Collaborator

@cegerard Sounds fine to me. I'm going to go ahead and merge both of your PRs. Thanks again for your work!

@austinkelleher austinkelleher merged commit 6aebdff into marko-js-archive:master Nov 20, 2019
@austinkelleher
Copy link
Collaborator

Published [email protected]. Going to publish a new version of marko-starter too.

@cegerard cegerard deleted the add-request-headers-into-route branch November 20, 2019 22:23
@cegerard
Copy link
Contributor Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants