added support for environment variables in leiu of options #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I discovered an issue with ZIG_PATH_LINK. One moment. |
|
Disregard. It was a non-issue. |
kassane
reviewed
Dec 27, 2023
| // TODO: maybe support a file on the filesystem to configure install dir? | ||
| if(std.os.getenv("ZIG_INSTALL_DIR")) |install_dir| { |
There was a problem hiding this comment.
std.os.getenv not working on Windows, but try std.process.getEnvVarOwned is cross-platform.
kassane
reviewed
Dec 27, 2023
| @@ -119,6 +126,9 @@ fn getInstallDir(allocator: Allocator, options: GetInstallDirOptions) ![]const u | |||
|
|
|||
| fn makeZigPathLinkString(allocator: Allocator) ![]const u8 { | |||
| if (global_optional_path_link) |path| return path; | |||
| if (std.os.getenv("ZIG_PATH_LINK")) |path_link| { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for this PR was originally articulated by @marler8997 as a
// TODOon line 83.This PR proposes a rather minor change to effectively extend the current functionality of the two existing CLI options (
--install-dirand--path-link) such that they now will automatically inherit their values from environment variables (ZIG_INSTALL_DIRandZIG_PATH_LINK, respectively). Documentation (via the help messagezigup -h) was updated accordingly.